Skip to content

docs: improve isEmail option documentation - #2867

Open
PranavNagaraji wants to merge 1 commit into
validatorjs:masterfrom
PranavNagaraji:master
Open

docs: improve isEmail option documentation#2867
PranavNagaraji wants to merge 1 commit into
validatorjs:masterfrom
PranavNagaraji:master

Conversation

@PranavNagaraji

@PranavNagaraji PranavNagaraji commented Aug 24, 2026

Copy link
Copy Markdown

Summary of Changes

  • Added comprehensive IsEmailOptions and EmailHostMatcher JSDoc type definitions to src/lib/isEmail.js to explicitly document option structures, edge-case validation flags, and default behaviors.
  • Synchronized README.md to reflect missing default options (ignore_max_length and host_whitelist).
  • Refactored option descriptions for better clarity without altering functional runtime behavior.

References

  • Synchronized directly with RFC email specification edge cases handled in src/lib/isEmail.js (UTF-8 local parts, IP domain literals, domain/host matchers).

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a79ff98) to head (b70b7e1).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2867   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2599      2599           
  Branches       658       658           
=========================================
  Hits          2599      2599           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant